Closed turbolent closed 1 week ago
It might make sense to add some tests for the C API to ensure the headers and the library can be used successfully.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.59%. Comparing base (
68205d4
) to head (01da862
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It might make sense to add some tests for the C API to ensure the headers and the library can be used successfully.
Yes, totally! I wanted to do this a long time ago but there are so many things with a higher priority right now. Missing automated tests is why I flagged the C-API as experimental so far. Though, I am very happy about help and PRs. :)
@turbolent Thanks a lot for the fix!
config.h
definesWASMI_CONFIG_PROP
to define setters for configuration options aswasmi_config_##name##_set
. Just like for all other configuration options, this macro is used forcompilation_mode
. However, the function is exported from thec_api
crate with a different name.Fix the exported name and make it consistent with the other configuration options.