Upgrade Astro and Starlight versions

infomiho commented 4 months ago

Reported by user:

Starlight's sidebar doesn't include a trailing slash ("/") at the end of the URL, leading to a 301 redirect to the page. It is a minor thing, but SEO-wise it is not great. I tried to look it up online but couldn't find any solution 😦

Astro team response:

You are on an older version Quite an old version of the 3 libraries starlight-blog fixed the trailing slash on 0.6.0, but your project is on 0.4.0 It requires Astro 4 and Starlight 0.19 since 0.5.0, but your project is using Astro 3 and Starlight 0.13 You might want to upgrade them

Thread: https://ptb.discord.com/channels/686873244791210014/1232786035230904341/1232786035230904341

We should upgrade our Astro version and Starlight version to get the benefits of latest fixes.

lakshaygoyal01 commented 4 months ago

Hi @infomiho, I want to work on this issue. Can you please assign this to me?

rbatista191 commented 4 months ago

As discussed in Discord, here is my first try at it:

Ricardos-MacBook-Pro:aiblogarticles1 rbatista19$ cd blog
Ricardos-MacBook-Pro:blog rbatista19$ npx @astrojs/upgrade

 astro   Integration upgrade in progress.

      ◼  @astrojs/tailwind is up to date on v5.1.0
      ●  @astrojs/check will be updated to v0.5.10
      ●  @astrojs/starlight will be updated to v0.21.5
      ●  @astrojs/starlight-tailwind will be updated to v2.0.2
      ▲  astro will be updated to  v4.7.0 

  wait   One package has breaking changes. Continue?
         Yes

 check   Be sure to follow the CHANGELOG.
         astro Upgrade to Astro v4

 ██████  Installing dependencies with npm...

      ▲  error Dependencies failed to install, please run the following command manually:
npm install @astrojs/check@0.5.10 @astrojs/starlight@0.21.5 @astrojs/starlight-tailwind@2.0.2 astro@4.7.0
Ricardos-MacBook-Pro:blog rbatista19$ npm install @astrojs/check@0.5.10 @astrojs/starlight@0.21.5 @astrojs/starlight-tailwind@2.0.2 astro@4.7.0
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: docs@0.0.1
npm ERR! Found: @astrojs/starlight@0.13.0
npm ERR! node_modules/@astrojs/starlight
npm ERR!   peer @astrojs/starlight@">=0.9.0" from @astrojs/starlight-tailwind@2.0.1
npm ERR!   node_modules/@astrojs/starlight-tailwind
npm ERR!     @astrojs/starlight-tailwind@"2.0.2" from the root project
npm ERR!   peer @astrojs/starlight@">=0.11.0" from starlight-blog@0.4.0
npm ERR!   node_modules/starlight-blog
npm ERR!     starlight-blog@"^0.4.0" from the root project
npm ERR!   1 more (the root project)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! @astrojs/starlight@"0.21.5" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: astro@4.7.0
npm ERR! node_modules/astro
npm ERR!   peer astro@"^4.2.7" from @astrojs/starlight@0.21.5
npm ERR!   node_modules/@astrojs/starlight
npm ERR!     @astrojs/starlight@"0.21.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/rbatista19/.npm/_logs/2024-04-29T16_28_36_980Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/rbatista19/.npm/_logs/2024-04-29T16_28_36_980Z-debug-0.log

vincanger commented 4 months ago

resolved in https://github.com/wasp-lang/open-saas/pull/122

wasp-lang / open-saas

Upgrade Astro and Starlight versions #111