wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.
https://wasp-lang.dev
MIT License
13.68k stars 1.18k forks source link

Fix dependency version checking #1859

Open sodic opened 7 months ago

sodic commented 7 months ago

This is how how Wasp consolidates user dependencies with framework dependencies as of Wasp 0.12.0 (taken from original discussion in https://github.com/wasp-lang/wasp/pull/1602#discussion_r1431438802):

For each dependency, decide which version we allow.

Since our version conflict check uses single string comparisons (instead of semantically comparing version ranges), it sometimes reports false positives.

For example:

Martinsos commented 7 months ago

This might be become redundant if we go with aliasing wasp deps, since then there is no conflict anymore and we don't need the check anymore.

Edit by @sodic: this one: https://github.com/wasp-lang/wasp/issues/1644

infomiho commented 2 months ago

In order to make this happen, we would need to write a parser for semver so we can semantically compare Wasp dep version with user's dep version.

We decided to shelf this task because we feel it's a part of a bigger picture (npm workspaces, aliasing npm deps etc.) and this issue might disappear all together in a different future setup.