wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.
https://wasp-lang.dev
MIT License
12.73k stars 1.13k forks source link

inform users which ENV VARS get set by `wasp deploy fly launch` #2055

Closed vincanger closed 1 month ago

vincanger commented 1 month ago

it's unclear which (server) ENV VARS are set automatically and which VARS users need to set themselves when deploying via wasp deploy fly launch.

Since Wasp automatically sets the following vars (below) via the deploy command, it would be best if we informed the user about this:


https://github.com/wasp-lang/wasp/blob/main/waspc/packages/deploy/src/providers/fly/setup/setup.ts#L116

const secretsArgs = [
        `JWT_SECRET=${randomString}`,
        // NOTE: Normally these would just be envars, but flyctl
        // doesn't provide a way to set envars that persist to fly.toml.
        'PORT=8080',
        `WASP_WEB_CLIENT_URL=${deploymentInfo.clientUrl}`,
        `WASP_SERVER_URL=${deploymentInfo.serverUrl}`,
    ];
Martinsos commented 1 month ago

Duplicate of #2053, so I will close it, but I will copy your comment there because it provides extra ideas.