search

wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.
https://wasp-lang.dev
MIT License
12.7k stars 1.13k forks source link

Add instructions for adding www subdomain to a Fly deployment #2084

Closed Case-E closed 2 weeks ago

Case-E commented 3 weeks ago

Description

Updated the docs with instructions on how to add a www subdomain.

Select what type of change this PR introduces:

  1. [x] Just code/docs improvement (no functional change).
  2. [ ] Bug fix (non-breaking change which fixes an issue).
  3. [ ] New feature (non-breaking change which adds functionality).
  4. [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. [ ] I updated ChangeLog.md with description of the change this PR introduces.
  2. [ ] I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.
Case-E commented 3 weeks ago

@Martinsos Is there a way we can notify the team when we have contributions to Wasp or is just opening a PR enough?

Martinsos commented 3 weeks ago

@Case-E it should be enough, depends though on how thoroughly each member of the team follows the Github notifications :)!

I make sure to go through them every day or two, so if nobody else, I will usually pick it up. Now it was weekend though so it took a bit longer.

It isn't a bad idea to write about it though, and if you wanted to do so, the best place would probably be the #development channel in Discord!

Btw this contribution is looking great, let me share with team on the internal Discord to see if anybody wants to take a lead on reviewing this.

Case-E commented 2 weeks ago

Thank you @Martinsos! I looked at the contributing section and didn't see anything about if we need to reach out to someone on the team. Glad to hear that they would be picked up from the queue. 😄

Case-E commented 2 weeks ago

@infomiho Ready for a review and merge whenever you get a chance. Let me know if you'd like me to make any more changes.

Martinsos commented 2 weeks ago

Nice @Case-E , that is it! I added just one thing: header for the section you added, like this:

#### Adding www Subdomain

Merging!