wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.
https://wasp-lang.dev
MIT License
12.7k stars 1.13k forks source link

Awaiting an action in the client setup function prevents render #2097

Open sodic opened 2 weeks ago

sodic commented 2 weeks ago

Steps to reproduce:

  1. Go to waspc/todoApp/src/clientSetup.js.
  2. Make the function async and await an action inside (e.g., testingAction)
  3. Run wasp start, load localhost:3000 and see the blank white screen.

Code confirmed to cause the behavior:

import { testingAction } from 'wasp/client/operations'
import { sayHi } from './util'

export default async function setup() {
  console.log('This was called from the client setup function')
  await testingAction()
  sayHi()
}
Martinsos commented 2 weeks ago

@sodic why would this be a bug? It sounds to me like it is expected behaviour -> you put await in setup function for a client, of course rendering it postponed.

Here is from our docs about this function:

setupFn declares a Typescript function that Wasp executes on the client before everything else. It is expected to be asynchronous, and Wasp will await its completion before rendering the page. The function takes no arguments, and its return value is ignored.

You can use this function to perform any custom setup (e.g., setting up client-side periodic jobs).

So I would say this is expected, documented and desired behaviour! If you want to not wait for that action, you can just not await it.

sodic commented 2 weeks ago

@Martinsos The rendering isn't postponed, it never happens.

Martinsos commented 2 weeks ago

@Martinsos The rendering isn't postponed, it never happens.

Whoops! Ok, that is really weird!