search

wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.
https://wasp-lang.dev
MIT License
12.7k stars 1.13k forks source link

2016/discord: Add discord auth to social auth providers #2110

Closed wardbox closed 6 days ago

wardbox commented 1 week ago

Description

Adds discord auth to social auth providers. Contributes to #2016 but doesn't fix.

Select what type of change this PR introduces:

  1. [ ] Just code/docs improvement (no functional change).
  2. [ ] Bug fix (non-breaking change which fixes an issue).
  3. [x] New feature (non-breaking change which adds functionality).
  4. [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. [x] I updated ChangeLog.md with description of the change this PR introduces.
  2. [x] I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

  1. [x] I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
  2. [x] I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).
wardbox commented 1 week ago

Heads up I did have some test failures from both cabal test and the headless test, but wasn't seeing a clear reason they'd be failing. Very likely due to lack of familiarity with the test suite, might need some help deciphering those!

Martinsos commented 1 week ago

All right this is quite cool @wardbox ! @infomiho is the master of Auth, let's see what he says -> there will probably be changes needed and additions on top of this (I guess docs especially), but this is looking like a potentially good foundation!

wardbox commented 1 week ago

All right this is quite cool @wardbox ! @infomiho is the master of Auth, let's see what he says -> there will probably be changes needed and additions on top of this (I guess docs especially), but this is looking like a potentially good foundation!

I actually have no idea where my doc went, must have removed in a stash 🤔 will submit that shortly

infomiho commented 1 week ago

Great contribution @wardbox

You should fix the e2e tests by running ./run test:e2e:accept-all and committing the diff.

I've left a couple of initial comments now, please address them.

I'll be testing this locally and reviewing the code in more detail next.