Consider removing lodash as a core Wasp dependency

wasp-lang / wasp

The fastest way to develop full-stack web apps with React & Node.js.

https://wasp-lang.dev

MIT License

13.23k stars 1.18k forks source link

Consider removing lodash as a core Wasp dependency #659

Closed shayneczyzewski closed 1 month ago

shayneczyzewski commented 2 years ago

Filip noticed that we only use lodash in a single file to perform _.merge of configs.

$ pwd && rg "lodash"  
/home/filip/wasp/reviews/waspc
data/Generator/templates/server/src/config.js
2:import _ from 'lodash'

src/Wasp/Generator/WebAppGenerator.hs
87:            ("lodash", "^4.17.15"),
$

We might consider removing it. It's a big dependency anyway and we can easily implement this ourselves. It's also pretty popular and removing it would allow our users to decide on the version they want to use on their own.

Martinsos commented 2 years ago

Sounds good to me, nice catch!

codingmickey commented 1 year ago

Can I try on this issue?

Martinsos commented 1 year ago

Can I try on this issue?

Sure feel free to go for it!

codingmickey commented 1 year ago

before I tried it's done by someone, accept his pr 👍🏽

infomiho commented 1 month ago

We replaced lodash with lodash.merge (which only contains the merge fn we use) quite some time ago. This way we are minimising the size of deps and just using what we need. I'll close this issue since the goal of this issue was achieved IMHO.