wassimj / TopologicSverchok

Topologic custom nodes for sverchok on Blender3D
GNU Affero General Public License v3.0
83 stars 18 forks source link

issue when activating latest version #27

Closed Sinasta closed 2 years ago

Sinasta commented 2 years ago

i get this error when trying to activate the latest version of topologic sverchok:

Traceback (most recent call last): File "/usr/share/blender/3.2/scripts/modules/addon_utils.py", line 335, in enable mod = import(module_name) File "/home/sinasta/.config/blender/3.2/scripts/addons/TopologicSverchok-main/init.py", line 383, in imported_modules = make_node_list() File "/home/sinasta/.config/blender/3.2/scripts/addons/TopologicSverchok-main/init.py", line 378, in make_node_list module = importlib.import_module(f".{module_name}", base_name) File "/usr/lib/python3.10/importlib/init.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ModuleNotFoundError: No module named 'topologicsverchok.nodes.Topologic.IFCExportToHBJSON'

Sinasta commented 2 years ago

This gets fixed by renaming: nodes/Topologic/IFCExportToHBSJON.py to: nodes/Topologic/IFCExportToHBJSON.py

Sinasta commented 2 years ago

And line 259 in init.py should be changed from: ("Topologic.TopologyByImportedIFC", "SvTopologyByImportedIFC",] to: ("Topologic.TopologyByImportedIFC", "SvTopologyByImportedIFC")] i think. Thank you for your work Wassim.

wassimj commented 2 years ago

Yes sorry! fixing it now!

Sinasta commented 2 years ago

Thank you very much! There is another issue, maybe it is just me, but i don't see the new node: IFC.ExportToHBJSON

wassimj commented 2 years ago

Can you check this? https://github.com/wassimj/TopologicSverchok/blob/v0.8.0.1/nodes/Topologic/IFCExportToHBSJON.py

wassimj commented 2 years ago

I have updated github and the binary release for Windows. Can you please check again? Much appreciated.

Sinasta commented 2 years ago

I still can't see the new node sadly: Screenshot from 2022-04-08 17-03-06

Sinasta commented 2 years ago

and i think you should rename the file from IFCExportToHBSJON.py to IFCExportToHBJSON.py. The S and J are switched and it seems to me like a typo. But even with the changement it doesn't appear in the node tree (see screenshot)

wassimj commented 2 years ago

Really sorry! Thanks for catching it. It should all be fixed now. (I hope!)

Sinasta commented 2 years ago

Thank you for your work. I installed the addon with your latest changes but i still can't find the IFCExportToHBJSON node. Screenshot from 2022-04-09 16-38-45

wassimj commented 2 years ago

I am suspecting it is not displaying it for you because you do not have honeybee installed. Please check the error outputs. There is probably a warning about that.

Sinasta commented 2 years ago

i don't have any error when starting blender and i have honeybee and ladybug installed. I am able to run the import part of IFCExportToHBJSON.py in Blender without problems (see screenshot). Screenshot from 2022-04-09 18-22-10

wassimj commented 2 years ago

Do you also have openstudio installed? Do you see the EnergyModel nodes?

Sinasta commented 2 years ago

yes i have openstudio 3.3.0 installed and i do see the EnergyModel nodes. Screenshot from 2022-04-09 19-12-40

wassimj commented 2 years ago

Then please check if the name is correct in two locations inside init.py and if the file is in the nodes/Topologic folder

Sinasta commented 2 years ago

The name is indeed correct in both locations in the init.py and the file does exist in the topologic folder. Another thing i just realised is that i am missing the HBJSONByTopology node.

Sinasta commented 2 years ago

now i added this line: ("Topologic.HBJSONByTopology", "SvHBJSONByTopology"), at line 267 in the init.py and now the EnergyModel.HBJSONByTopology just appeared in the nodetree. I don't know if both problems are related.

wassimj commented 2 years ago

Sorry not at my computer now. Will investigate

Sinasta commented 2 years ago

I think i fixed the problem by replacing: SvHBJSONByIFC with SvIFCExportToHBJSON in the IFCExportToHBJSON.py file

wassimj commented 2 years ago

That explains it! A case of copy paste error. I will fix soon

Sinasta commented 2 years ago

Oh and i was missing the Neo4jGraphNodeLabels node. Which git fixed by replacing: SvNeo4jGraphNodelLabels with SvNeo4jGraphNodeLabels in the init.py. It seems to me that this is a typo aswell. I will continue to check a bit if i am missing other nodes and than report.

Sinasta commented 2 years ago

replacing SvSpeckleRecieve with SvSpeckleReceive in the init.py makes the Speckle.Receive node appear.

wassimj commented 2 years ago

That is surprising. I know these are nodes that I recently used.

Sinasta commented 2 years ago

adding the line: ("Topologic.EnergyModelExportToHBJSON", "SvEnergyModelExportToHBJSON"), to the init.py on line 271 makes the node: EnergyModel.ExportToHBJSON appear

Sinasta commented 2 years ago

I checked everything and the rest seems to be fine. There are some seemingly depracted nodes that are still called in the init.py:

SvEdgeSharedVertices SvFaceTriangulate SvTopologyContexts

I guess those could be deleted but doesnt matter apparently.

SvEnergyModelByImportedIFC seems to be drawn twice, once in Openstudio submenu and once in IFC submenu (it seems that it fits more in the Openstudio submenu and could be deleted from the IFC submenu)

wassimj commented 2 years ago

Thank you. Listing SvEnergyModelByIMportedIFC in two places was done by design 🙂. If you don't mind, I will leave it as is.

wassimj commented 2 years ago

All the above issues should've been fixed in the following release. Kindly verify and let me know if you continue to find issues with it. Thank you for your efforts in finding these problems. https://github.com/wassimj/TopologicSverchok/releases/tag/v0.8.0.2

Sinasta commented 2 years ago

Thank's for the effort i really appreciate your work on topologic. With your latest changes there is still the EnergyModel.HBJSONByTopology node missing. which gets fixed with this:

now i added this line: ("Topologic.HBJSONByTopology", "SvHBJSONByTopology"), at line 267 in the init.py and now the EnergyModel.HBJSONByTopology just appeared in the nodetree. I don't know if both problems are related.

Furthermore the Neo4jGraph.NodeLabels is missing in the nodetree. That gets fixed by:

Oh and i was missing the Neo4jGraphNodeLabels node. Which git fixed by replacing: SvNeo4jGraphNodelLabels with SvNeo4jGraphNodeLabels in the init.py. It seems to me that this is a typo aswell. I will continue to check a bit if i am missing other nodes and than report.

The rest seems to be fixed now :)

wassimj commented 2 years ago

Thank you. HBJSON.ByTopology is deprecated and should not be added to init. Instead, use EnergyModelExportToHBJSON I will fix the mis-spelled SvNeo4jGraphNodeLabels in the init file. Thank you for your eagle eyes.

Sinasta commented 2 years ago

Oh that is good to know :) BTW i would appreciate a lot if you could somehow spare some time to give some explanations on how to use all the honeybee/openstudio functionalities (i know that there is your video on youtube but you added plenty of new functions and i would appreciate an update on the usage). Basically what i would like to achieve is to 'evaluate' somehow the energy performance (and potentially lightning performance with radiance aswell as airflow with openfoam somehow similar to the ladybug suite in grasshopper) of a cell complex with apertures (doors, window, shading surfaces). I don't know if this is already possible or if the vi-suite addon should be used for that purpose for now. Thanks anyways for your awesome work :)

wassimj commented 2 years ago

energy performance is possible, but not lighting and airflow at this moment. I need the help of experts in these areas to see what is needed. I know the are ladybug nodes in sverchok that can be useful? When I have some free time, I will do a workshop on energy analysis.

Sinasta commented 2 years ago

perfect i would love to see a small workshop on energy performance. For what concerns ladybug and openfoam integration i have the feeling that Ryan Southall with his Blender addon Vi-suite could be of good help to integrate Radiance, energy+ and openfoam in topologic sverchok.