search

watadarkstar / react-native-typing-animation

💬 A typing animation for your React Native chat app based on simple trigonometry to create better loaders.
https://www.npmjs.com/package/react-native-typing-animation
MIT License
282 stars 15 forks source link

Remove .git directory from npm package. #2

Closed azzadrood closed 5 years ago

azzadrood commented 5 years ago

Hello,

I have this error when i try to install another package to my project after i have installed your package.

Screenshot 2019-03-28 at 14 16 26

So i have to enter node-modules/react-native-typing-animation and remove .git directory.

Screenshot 2019-03-28 at 14 15 45

Can you remove .git folder from npm package?

Thank you in advanced.

Btw very nice animation!

watadarkstar commented 5 years ago

@azzadrood Can you update to 0.1.7 it might be fixed, I added the .git to the .gitignore but im not sure if this will actually work. Can you test it and let me know?

EDIT: It should work based on this https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package. Though it is odd because the .git should already be ignored.

By default, the following paths and files are ignored, so there’s no need to add them to .npmignore explicitly:

..swp ._ .DS_Store .git .hg .npmrc .lock-wscript .svn .wafpickle-* config.gypi CVS npm-debug.log

azzadrood commented 5 years ago

Hello i have tested right now and I can confirm that it works well. Thanks!

watadarkstar commented 5 years ago

Sounds good glad it worked @azzadrood