watchexec / command-group

Deprecated: use process-wrap. || Extension to Command to spawn in a process group
https://docs.rs/command-group
Other
37 stars 10 forks source link

fix `wait_imp` on windows #13

Closed chronicl closed 1 year ago

chronicl commented 1 year ago

The wrong raw pointer was being null checked here. This lead to a timeout error every time the method was called and the Child hadn't compeleted it's work yet. See here for more details.

passcod commented 1 year ago

Huh. Thanks! Any chance you could check out the tokio implementation for this?

chronicl commented 1 year ago

Made the same changes to the tokio implementation too!