search

watchexec / command-group

Deprecated: use process-wrap. || Extension to Command to spawn in a process group
https://docs.rs/command-group
Other
37 stars 10 forks source link

Possible soundness issue in ChildImp::wait #20

Open gigaroby opened 1 year ago

gigaroby commented 1 year ago

While conducting an internal unsafe review, we identified a possible soundness issue in ChildImp::wait

https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/tokio/child/windows.rs#L100-L104

This function and the one below call the Clone impl that appears to undermine the unsafe Drop impl on self.handles.

passcod commented 1 year ago

This is the same root issue as the other one you just opened, yeah?