search

watchexec / command-group

Deprecated: use process-wrap. || Extension to Command to spawn in a process group
https://docs.rs/command-group
Other
37 stars 10 forks source link

Upgrade nix dependency to 0.26.1, limit features #8

Closed rtzoeller closed 1 year ago

rtzoeller commented 1 year ago

Supersedes #5

passcod commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build failed:

rtzoeller commented 1 year ago

Looks like a miss on my part - that module isn't used on Linux. Will fix.

rtzoeller commented 1 year ago

@passcod can we try again?

passcod commented 1 year ago

bors retry

bors[bot] commented 1 year ago

Build failed:

rtzoeller commented 1 year ago

Build failed:

* [Test on macos with Rust 1.51.0 (feat: default)](https://github.com/watchexec/command-group/actions/runs/3606837968/jobs/6078457901)

That error doesn't look particularly related to my changes, and I'm a bit skeptical. @passcod any ideas?

passcod commented 1 year ago

hmm I'll run a try from unmodified code in #9, see if that appears

passcod commented 1 year ago

Looks like it's specifically on 1.51. I might just bump this crate's msrv; I'll figure out an appropriate one later today

rtzoeller commented 1 year ago

Looks like it's specifically on 1.51. I might just bump this crate's msrv; I'll figure out an appropriate one later today

No real preference from me, but if you end up at 1.56 or higher let me know and I will update this PR to target nix 0.26. I'm fine leaving it at 0.25 though, if you prefer an older MSRV.

passcod commented 1 year ago

Yeah I'm going with 1.60