search

watchforstock / evohome-client

Python client to access the Evohome web service
Apache License 2.0
88 stars 52 forks source link

Allow system mode until with hours, minutes #104

Closed zxdavb closed 4 years ago

zxdavb commented 4 years ago

The system AutoWithEco mode has an 'official' resolution of hours in the Controller UI, but will work with minutes. Other modes, e.g. Away, have a resolution of days, but appears to work with (say) hours.

The client library rounds down all TimeUntils for _set_status() to midnight, this precludes the full extent of the above functionality.

This is the fix - to remove the rounding.

I have not tested on this client, but it is a very simple fix, and the equivalent fix has been tested on evohome-async.

zxdavb commented 4 years ago

@watchforstock if you merge this - would you mind tagging it as 0.3.5, so I can align the async version with yours? Ta

watchforstock commented 4 years ago

@watchforstock if you merge this - would you mind tagging it as 0.3.5, so I can align the async version with yours? Ta

I've tagged it as release 0.3.6 (because I messed up the 0.3.5 tag!)