Closed zxdavb closed 4 years ago
Addresses issue #108
So this is a blackened version of the library - basic testing says it works OK.
CircleCI will fail because of pylint - we should drop pylint, everything needed will be in flake8 & black.
I have also created the pre-commit stuff, to enforce flake8, black & isort - you need to:
git clone https://github.com/watchforstock/evohome-client cd evohome-client python3 -m venv venv pip install --upgrade pip pip install -r requirements-dev.txt pre-commit install-hooks
Then it should work. You can also, at any time, run:
pre-commit run --all-files
I don't know CircleCI well enough to add black/flake8 to it, but this can be done - could you take that on as well as remove pylint?
Shall we update the requirements to the latest version? Do we need Pipfile.lock at all?
Addresses issue #108
So this is a blackened version of the library - basic testing says it works OK.
CircleCI will fail because of pylint - we should drop pylint, everything needed will be in flake8 & black.
I have also created the pre-commit stuff, to enforce flake8, black & isort - you need to:
Then it should work. You can also, at any time, run:
Notes
I don't know CircleCI well enough to add black/flake8 to it, but this can be done - could you take that on as well as remove pylint?
Shall we update the requirements to the latest version? Do we need Pipfile.lock at all?