search

watchforstock / evohome-client

Python client to access the Evohome web service
Apache License 2.0
88 stars 52 forks source link

Data no longer automatically refreshed when calling EvohomeClient.temperatures() #89

Closed tmacecode closed 5 years ago

tmacecode commented 5 years ago

Sorry this may be a deliberate change and not a bug, but in the previous release (0.2.8) a call to EvohomeClient.temperatures() would result in the status data being refreshed due to line 73 of controlsystem.py

status = self.location.status()

But in the latest version (0.3.1) that status call doesn't exist.

Is the intention now that the user has to manually request that the status data is refreshed?

watchforstock commented 5 years ago

Thanks for the report - I don't believe this was intentional (or at least I don't recall a discussion about it). It looks like in this commit (https://github.com/watchforstock/evohome-client/commit/f57fd55020a7bdb6a409a60f6b91025ea82dbb9b#diff-91be0e17c72f324a8437009c3c5c42bb) @zxdavb commented it out and presumably it was then subsequently removed. David, any view as to whether there was a reason behind this change?

zxdavb commented 5 years ago

@watchforstock I am sorry!

I think I was testing an idea, and then deleted the line, rather than properly remove the #.

I'd say it should definitely go back in!

zxdavb commented 5 years ago

TBH, the amount of refactoring that went on, we're lucky the bloody thing hasn't exploded!

watchforstock commented 5 years ago

@zxdavb Indeed! Thanks for the PR. @tmacecode This should now be fixed in master, but isn't yet in a released version.

tmacecode commented 5 years ago

That is great, thank you.

How often do you cut a new release?

From: Andrew Stock [mailto:notifications@github.com] Sent: 18 March 2019 00:52 To: watchforstock/evohome-client Cc: tmacecode; Mention Subject: Re: [watchforstock/evohome-client] Data no longer automatically refreshed when calling EvohomeClient.temperatures() (#89)

@zxdavb https://github.com/zxdavb Indeed! Thanks for the PR. @tmacecode https://github.com/tmacecode This should now be fixed in master, but isn't yet in a released version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/watchforstock/evohome-client/issues/89#issuecomment-473733931 , or mute the thread https://github.com/notifications/unsubscribe-auth/AtCbFiqVcnglxMFqYMZPIeVqWZki31obks5vXuMWgaJpZM4b3JZp . https://github.com/notifications/beacon/AtCbFhrHeUHGfJSGXfr2vRjBdjk9mhIIks5vXuMWgaJpZM4b3JZp.gif

watchforstock commented 5 years ago

@tmacecode v0.3.2 is now available on pypi with this change in it...

tmacecode commented 5 years ago

Fantastic, thank you.

From: Andrew Stock [mailto:notifications@github.com] Sent: 20 March 2019 14:11 To: watchforstock/evohome-client Cc: tmacecode; Mention Subject: Re: [watchforstock/evohome-client] Data no longer automatically refreshed when calling EvohomeClient.temperatures() (#89)

@tmacecode https://github.com/tmacecode v0.3.2 is now available on pypi with this change in it...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/watchforstock/evohome-client/issues/89#issuecomment-474846540 , or mute the thread https://github.com/notifications/unsubscribe-auth/AtCbFs-98IqQ0tc2KTiupWPDKfAHuRTzks5vYkGKgaJpZM4b3JZp . https://github.com/notifications/beacon/AtCbFonfWTE0uVAXMMQT920dW7TkCZ4nks5vYkGKgaJpZM4b3JZp.gif