search

watea / RadioUpnp

Android RadioUpnp application.
MIT License
31 stars 6 forks source link

Light theme #6

Closed xmha97 closed 1 month ago

xmha97 commented 1 year ago

Please add the light theme to the app. Thanks 🙏

watea commented 1 year ago

Yes I know it should be done, thanks for recalling that! If I ever find time ;)

Feel free to contribute. I will accept the pull request if the light mode is added only using Android design patterns; switch only using app theme (res/values/styles.xml) switch, no data in other resources. Sure a setting menu in navigation menu is necessary to let the user choose between dark/light/system theme.

Regards.

ovizii commented 1 year ago

Yes please. The current theme has a very low contract unfortunately, I can barely read the dark grey on black text. This is what it looks like when I add a station.

Screenshot_20230707-102028_RadioUpnp

watea commented 1 year ago

Thanks for feedback. Not done yet because the current layout is mostly based on default colours, which was the easiest way. Tailoring that requires to adjust quiet a lot of features, and it was not the priority till now.

watea commented 1 month ago

Hi,

Layout improvement and theme selection is added in https://github.com/watea/RadioUpnp/tree/V2.71.00.

Regards.