watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Add function to enable resampling to 10 minutes #54

Closed Sachagobeyn closed 2 years ago

Sachagobeyn commented 2 years ago

The input data for computing the R-factor should be equal to 10 minutes as this is the resolution on which the formula's are based. A resampling methodology for timeseries with another resolution is added. This can be used by users to resample. The workflow is as follows:

To do:

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on this branch

Sachagobeyn commented 2 years ago

@johanvdw , @stijnvanhoey : do you have any idea why https://github.com/cn-ws/rfactor/runs/6160368522?check_suite_focus=true pops up?

@stijnvanhoey : I implemented a decorator function to check rainfall input data (with input parameters for the decorator function with the itertool wraps function). Yet, this reminds me of https://github.com/keleshev/schema, do you think it is it applicable here?

stijnvanhoey commented 2 years ago

@johanvdw , @stijnvanhoey : do you have any idea why https://github.com/cn-ws/rfactor/runs/6160368522?check_suite_focus=true pops up?

To solve this, switch the git://github... into https://github... in the pre-commit configuration on line 4 https://github.com/cn-ws/rfactor/blob/master/.pre-commit-config.yaml#L4

Sachagobeyn commented 2 years ago

@stijnvanhoey : thanks for the comments, valid.py is a new script + test files added + docs on how to use resampling function is also provided. I'll merge when drone is finished.