Update file handling - Githubissues

watem-sedem / rfactor

R-factor

https://watem-sedem.github.io/rfactor/

GNU Lesser General Public License v3.0

6 stars 2 forks source link

Update file handling #62

Closed Sachagobeyn closed 1 year ago

Sachagobeyn commented 1 year ago

This PR adds the VMM CSV file legacy to the process-module of the package. It aims to standerdize the input for the VMM CSV format used since 2018 for the computations for Flanders.

github-actions[bot] commented 1 year ago

:point_left: Launch a binder notebook on this branch

Sachagobeyn commented 1 year ago

To do @Sachagobeyn:

[ ] Compute diagnostics outside of load function

Questions:

Do we need to consider more input formats? @SethCallewaert

Sachagobeyn commented 1 year ago

@SethCallewaert : diagnostics is split and is a seperate functionality now.

Sachagobeyn commented 1 year ago

@SethCallewaert : added example diagnostics in notebook (analysis_flanders.ipynb), ping me for questions.

daarende commented 1 year ago

I did some small fixes in the tests and code to get everything running, but the assertion in test_compute_diagnostics is not correct. @Sachagobeyn can you check this?

Sachagobeyn commented 1 year ago

I did some small fixes in the tests and code to get everything running, but the assertion in test_compute_diagnostics is not correct. @Sachagobeyn can you check this?

@daarende : I'm not sure what the issue was but by merging master and rerunning precommit the done completes (+ commit e03bc97, maybe the issue was there)

Sachagobeyn commented 1 year ago

We'll wait for feedback VPO before merging

daarende commented 1 year ago

(@Sachagobeyn do you know why the ci is pending?)

Sachagobeyn commented 1 year ago

@SethCallewaert : we merged this for sake of proceeding