search

watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Redundant codeline #65

Closed SethCallewaert closed 2 months ago

SethCallewaert commented 1 year ago

Isn't line: https://github.com/cn-ws/rfactor/blob/d27f7478790a71fbdb2ed266eb25e84a5c2d862a/src/rfactor/rfactor.py#L192 redundant since the inputfiles need to be void of 0 values?

Or is this a backdoor in order to enable complete datafiles in the function?

Sachagobeyn commented 3 months ago

@SethCallewaert : we include this to avoid 0's are included (I believe this was discussed before). This is a historical definition, and reduces runtime. Alternatively we can implement a IO-Error to avoid people input 0's, as of now we have implemented a warning (see https://github.com/watem-sedem/rfactor/blob/master/src/rfactor/rfactor.py#L295). Does this cover your question?

Sachagobeyn commented 2 months ago

Hi @SethCallewaert : it is adjusted in https://github.com/watem-sedem/rfactor/pull/85