watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

load_rain_folder without given function #67

Closed SethCallewaert closed 6 months ago

SethCallewaert commented 1 year ago

Is it possible to make load_rain_folder take the function load_rain_file_matlab_legacy as default if no function is given. This could be useful in order to guarantee older scripts can still run correctly without rewriting their code. https://github.com/cn-ws/rfactor/blob/d27f7478790a71fbdb2ed266eb25e84a5c2d862a/src/rfactor/process.py#L335

Sachagobeyn commented 6 months ago

Hi @SethCallewaert : I'm not sure if I understand correctly. It is possible, yet there is - from a technical point of view - not adviced, since new users would be "blind" to the format.

Which older scripts you refer to? In theory, the scripts should follow the releases of R-factor (to follow-up on compatibility)