search

watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Test fails #69

Closed daarende closed 1 year ago

daarende commented 1 year ago

In the CI the python tests of the rfactor package fail. See for example https://github.com/cn-ws/rfactor/actions/runs/3872291489/jobs/6600972677

============================= test session starts ==============================
platform linux -- Python 3.8.15, pytest-7.2.0, pluggy-1.0.0 -- /opt/hostedtoolcache/Python/3.8.15/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/rfactor/rfactor, configfile: setup.cfg, testpaths: tests
plugins: datafiles-2.0.1, anyio-3.6.2, xdist-3.1.0, cov-4.0.0
collecting ... collected 69 items

tests/test_process.py::test_resample_rainfall[idx0-values0-1H-idx_n0-values_n0-10T] PASSED [  1%]
tests/test_process.py::test_resample_rainfall[idx1-values1-15T-idx_n1-values_n1-10T] PASSED [  2%]
tests/test_process.py::test_resample_rainfall[idx2-values2-15T-idx_n2-values_n2-20T] PASSED [  4%]
tests/test_process.py::test_resample_rainfall[idx3-values3-15T-idx_n3-values_n3-10T] PASSED [  5%]
tests/test_process.py::test_days_since_last_year_float PASSED            [  7%]
tests/test_process.py::test_days_since_last_year_single_year PASSED      [  8%]
tests/test_process.py::test_extract_metadata_from_file_path[UKKEL_2002.txt-UKKEL-2002] PASSED [ 10%]
tests/test_process.py::test_extract_metadata_from_file_path[U_K_K_E_L_1998.txt-U_K_K_E_L-19980] PASSED [ 11%]
tests/test_process.py::test_extract_metadata_from_file_path[U_K_K_E_L_1998.txt-U_K_K_E_L-19981] PASSED [ 13%]
tests/test_process.py::test_extract_metadata_from_file_path[UK-KEL_1998.txt-UK-KEL-1998] PASSED [ 14%]
tests/test_process.py::test_extract_metadata_from_file_path_invalid[UKKEL_2002---.txt] PASSED [ 15%]
tests/test_process.py::test_extract_metadata_from_file_path_invalid[UKKEL_2002_.txt] PASSED [ 17%]
tests/test_process.py::test_extract_metadata_from_file_path_invalid[UKKEL_202.txt] PASSED [ 18%]
tests/test_process.py::test_extract_metadata_from_file_path_invalid[UKKEL20022.txt] PASSED [ 20%]
tests/test_process.py::test_extract_metadata_from_file_path_invalid[2002.txtUKKEL.txt] PASSED [ 21%]
tests/test_process.py::test_check_path PASSED                            [ 23%]
tests/test_process.py::test_load_rain_file PASSED                        [ 24%]
tests/test_process.py::test_compute_diagnostics PASSED                   [ 26%]
tests/test_process.py::test_load_rain_file_with_folder PASSED            [ 27%]
tests/test_process.py::test_load_rain_folder PASSED                      [ 28%]
tests/test_process.py::test_load_rain_folder_with_file PASSED            [ 30%]
tests/test_process.py::test_write_erosivity PASSED                       [ 31%]
tests/test_process.py::test_rfactor_from_erosivity PASSED                [ 33%]
tests/test_process.py::test_rfactor_from_erosivity_subset PASSED         [ 34%]
tests/test_process.py::test_rfactor_from_erosivity_subset_not_existing PASSED [ 36%]
tests/test_process.py::test_rainfall_statistics PASSED                   [ 37%]
tests/test_process.py::test_rainfall_statistics_with_metadata PASSED     [ 39%]
tests/test_rfactor.py::test_rain_energy_per_unit_depth[rain0-0.0] PASSED [ 40%]
tests/test_rfactor.py::test_rain_energy_per_unit_depth[rain1-0.0] PASSED [ 42%]
tests/test_rfactor.py::test_rain_energy_per_unit_depth[rain2-nan] PASSED [ 43%]
tests/test_rfactor.py::test_rain_energy_per_unit_depth[rain3-0.19379] PASSED [ 44%]
tests/test_rfactor.py::test_rain_energy_per_unit_depth[rain4-0.73891] PASSED [ 46%]
tests/test_rfactor.py::test_maximum_intensity[rain_mm0-6.0] PASSED       [ 47%]
tests/test_rfactor.py::test_maximum_intensity[rain_mm1-0.0] PASSED       [ 49%]
tests/test_rfactor.py::test_maximum_intensity[rain_mm2-168.0] PASSED     [ 50%]
tests/test_rfactor.py::test_maximum_intensity_nan PASSED                 [ 52%]
tests/test_rfactor.py::test_maximum_intensity_matlab_multiple_years PASSED [ 53%]
tests/test_rfactor.py::test_maximum_intensity_short PASSED               [ 55%]
tests/test_rfactor.py::test_compute_erosivity_wrong_df PASSED            [ 56%]
tests/test_rfactor.py::test_compute_0_or_NULL_rain_mm_warning PASSED     [ 57%]
tests/test_rfactor.py::test_apply_rfactor PASSED                         [ 59%]
tests/test_rfactor.py::test_erosivity_rain_single_yearstation PASSED     [ 60%]
tests/test_rfactor.py::test_erosivity_rain_single_yearstation_wrong_datetime_dtype PASSED [ 62%]
tests/test_rfactor.py::test_erosivity_rain_single_yearstation_wrong_station_dtype PASSED [ 63%]
tests/test_rfactor.py::test_erosivity_rain_single_yearstation_wrong_rain_dtype PASSED [ 65%]
tests/test_rfactor.py::test_erosivity_rain_single_yearstation_missing_column PASSED [ 66%]
tests/test_rfactor.py::test_erosivity_existing_tag PASSED                [ 68%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_001-2018-maximum_intensity] PASSED [ 69%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_001-2018-maximum_intensity_matlab_clone] FAILED [ 71%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_003-2020-maximum_intensity] PASSED [ 72%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_003-2020-maximum_intensity_matlab_clone] FAILED [ 73%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_010-2012-maximum_intensity] PASSED [ 75%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_010-2012-maximum_intensity_matlab_clone] FAILED [ 76%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_010-2016-maximum_intensity] PASSED [ 78%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P01_010-2016-maximum_intensity_matlab_clone] FAILED [ 79%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P05_038-2018-maximum_intensity] PASSED [ 81%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P05_038-2018-maximum_intensity_matlab_clone] FAILED [ 82%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P05_039-2017-maximum_intensity] PASSED [ 84%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P05_039-2017-maximum_intensity_matlab_clone] FAILED [ 85%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P08_018-2012-maximum_intensity] PASSED [ 86%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P08_018-2012-maximum_intensity_matlab_clone] FAILED [ 88%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P09_032-2020-maximum_intensity] PASSED [ 89%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P09_032-2020-maximum_intensity_matlab_clone] FAILED [ 91%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P11_007-2008-maximum_intensity] PASSED [ 92%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P11_007-2008-maximum_intensity_matlab_clone] FAILED [ 94%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P11_024-2012-maximum_intensity] PASSED [ 95%]
tests/test_rfactor.py::test_rfactor_benchmark_single_year[P11_024-2012-maximum_intensity_matlab_clone] FAILED [ 97%]
tests/test_rfactor.py::test_rfactor_full_benchmark SKIPPED (only wor...) [ 98%]
tests/test_valid.py::test_valid_rainfall_timeseries PASSED               [100%]

The test_rfactor_benchmark_single_year[maximum_intensity_matlab_clone] for all different stations fails.

daarende commented 1 year ago

This is only present on the feature branch of Seth, see https://github.com/cn-ws/rfactor/pull/68. Closing this issue as the PR is still WIP.