refactor: make choice of energy function an input

watem-sedem / rfactor

R-factor

https://watem-sedem.github.io/rfactor/

GNU Lesser General Public License v3.0

6 stars 2 forks source link

refactor: make choice of energy function an input #87

Closed Sachagobeyn closed 2 months ago

Sachagobeyn commented 2 months ago

The PR ensures users can implement and use their own custom energy function, equal to what is done for the ``maximum_intensity```function, see https://github.com/watem-sedem/rfactor/issues/82 and https://github.com/watem-sedem/rfactor/issues/80. This PR only ensures the compute_erosivity-function can take an addition input, it does not yet include more custom functions (or testing thereof).

@SethCallewaert @claudiacagn : can you both test the interface in analysis_flanders?

github-actions[bot] commented 2 months ago

:point_left: Launch a binder notebook on this branch

Sachagobeyn commented 2 months ago

To do:

[x] Tackle issues testing
[x] Discuss naming interpolate (in maximum intensity-function) & remove matlab with VPO.
[x] Refactor namling according to point one

Sachagobeyn commented 2 months ago

Hi, thank you seth, I'll adapt and merge.