watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

fix J/m2 to MJ/ha #93

Closed Sachagobeyn closed 1 month ago

Sachagobeyn commented 1 month ago

The documentation of the energy function (Verstraeten/Salles) did not allign with the implementation : the unit and documented now are:

$\frac{MJ}{mm.ha}$

The formula is divided by 100 J/m2/mm to MJ/ha/mm

@SethCallewaert : this closes https://github.com/watem-sedem/rfactor/issues/81?

github-actions[bot] commented 1 month ago

Binder :point_left: Launch a binder notebook on this branch

SethCallewaert commented 1 month ago

This makes more sense indeed! Should this, however, be changed in the documentation (https://github.com/watem-sedem/rfactor/blob/0638ed7000ada018ace1514c40ff67f6aed5b4ff/docs/rfactor.rst?plain=1#L59) as well?