watem-sedem / rfactor

R-factor
https://watem-sedem.github.io/rfactor/
GNU Lesser General Public License v3.0
6 stars 2 forks source link

add mcgregor; and brown and foster #94

Closed Sachagobeyn closed 2 months ago

Sachagobeyn commented 4 months ago

Adds McGregog; and Brown and Foster, to do:

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a binder notebook on this branch

Sachagobeyn commented 4 months ago

Also includes renaming as stated in https://github.com/watem-sedem/rfactor/issues/82#issuecomment-2129153189

Sachagobeyn commented 4 months ago

Formulas are now checked and corrected by @SethCallewaert (and @claudiacagn if you like). Note that all formulas apply on 10 minute resolution, I added this to the documentation and getting started

Sachagobeyn commented 4 months ago

Last to do:

Sachagobeyn commented 3 months ago

@SethCallewaert : I added unit tests for the Mcgregor / Brown and Foster formula.

Comparin both methods to Verstraeten, this is what I computed (using maximum intensity function):

Naamloos-1

and using maximum intensity matlab clone

Naamloos-2