search

water-hole / ansible-operator

POC Code for the operator backed by ansible
48 stars 29 forks source link

add API proxy #3

Closed mhrivnak closed 6 years ago

mhrivnak commented 6 years ago

Adds API proxy code from @fabianvf with refactors.

The original proxy code from kubernetes is preserved in a commit, with our changes in the next commit.

mhrivnak commented 6 years ago

Agreed on the binary. I was going to make a separate PR to remove it, but I'll happily do it here.

mhrivnak commented 6 years ago

I completely re-did Gopkg.toml, so please take a look.

ehelms commented 6 years ago

Mind adding a brief comment on what adding this API proxy is designed to do?

shawn-hurley commented 6 years ago

@ehelms The idea of the proxy is to transparently add ownerRefs to the resources created by ansible. This allows for the ansible code to not have to know the details of being an operator.

ehelms commented 6 years ago

So to recap my understanding, this is "intercepting" the API call Ansible makes to Kube with the resource, modifies it slightly and then passes that modified version on to Kube?

fabianvf commented 6 years ago

@ehelms correct