search

waterbearlang / waterbear

Visual block syntax for programming languages
http://waterbearlang.com/
357 stars 88 forks source link

Chord block and custom sound effect block #1289

Closed alexjsmac closed 8 years ago

alexjsmac commented 8 years ago

Not ready to merge, chord block is done, just need to make sound effect block.

CelticMinstrel commented 8 years ago

Are you thinking of synthesized or sampled sound effects?

alexjsmac commented 8 years ago

Synthesized, like the two that are in the list of the current sound effect block. The new block will allow users to make their own though.

CelticMinstrel commented 8 years ago

Okay, so what if you want a chord consisting of G4, B5, and D5? From what I can tell your interface won't allow that.

alexjsmac commented 8 years ago

@CelticMinstrel Ahh yeah that's true. Thanks I didn't mean to leave that out. It's fixed now.

CelticMinstrel commented 8 years ago

So rows can contain multiple values, huh? I guess that's good to know.

alexjsmac commented 8 years ago

Okay ready to merge!

alexjsmac commented 8 years ago

My tests added some output to npm test is that okay?

dethe commented 8 years ago

Looks good, just a couple of minor things to address and then :shipit:

alexjsmac commented 8 years ago

Okay I removed the log and alert. The issue for providing info with the keys block is #1311. Merging now :+1: