watercooler-labs / toggl-cli

🕐 Command Line App for Toggl Track
MIT License
31 stars 7 forks source link

Canonicalize path of Git root. #77

Closed trombonehero closed 3 months ago

trombonehero commented 3 months ago

When inside a Git worktree, the path to root can be relative, e.g., ../.git/modules/foo. When this happens, the attempt to get the root's parent's parent's parent fails to unwrap at config/model.rs:389, causing a panic. If we canonicalize the path first, this doesn't happen.

shantanuraj commented 3 months ago

It's live in v0.4.4 Thanks for your contribution @trombonehero! 🙌

trombonehero commented 3 months ago

Thanks for the quick response! Really appreciate this tool.