search

watergis / maplibre-gl-legend

This module adds legend control which is able to create legend panel from mapbox style to maplibre-gl-legend
https://maplibre-gl-legend.water-gis.com/
MIT License
31 stars 7 forks source link

"Close" button overlaps the scrollbar. #22

Open frafra opened 11 months ago

frafra commented 11 months ago

Scrollbar clashes with the "x"/close button.

https://github.com/watergis/maplibre-gl-legend/blob/de661ee8e05cfa85242c10fb3e0aced35a2e1ca9/packages/maplibre-gl-legend/src/scss/maplibre-gl-legend.scss#L6

image

Firefox 116. DEMO: https://maps.nina.no/datasets/planlagt-utbyggingsareal-i-norge/.

I wonder what would be appropriate here. Putting the cross on the left goes against the usual placement of this kind of button. Maybe a "v" button on the left to minimize/collapse the widget would be preferable?

JinIgarashi commented 11 months ago

@frafra Thank you for reporting the issue. I think putting a button to expand / collapse the content is good idea on the top-left. Feel free to create a PR for this issue.