search

waterjump / volca-share

:zap::musical_keyboard::zap: Share patches for the Korg Volca Bass synthesizer.
GNU General Public License v3.0
41 stars 6 forks source link

Fix event propagation issue with light toggles #2

Closed meowsus closed 5 years ago

meowsus commented 7 years ago

It was just an event propagation problem. The browser is giving me a weird visual delay on the checkboxes while dragging, but when I release the mouse all of the lights and checkboxes are in sync. N*sync. Whatever.

Definitely not worth a six-pack, but I'll take it if your insistent.

You should also break apart your forms.js.erb file into separate files. It's pretty unwieldy.

Kisses,

Curt

waterjump commented 7 years ago

Curt,

Thanks but this is built on top of my kludgey workaround from 05c84e88. I tested it and i can still make the initial light and it's checkbox replace different values if i drag over other lights, then back over the original without a mouseup.

The real challenge is making it work starting from commit 1f768419e0cef4cc7558afe91ed02d0acd413194

meowsus commented 7 years ago

Sorry bud. Had a kid. I'll try to take another stab soon, but I don't seem to be getting the same results as you. Maybe show me at work tomorrow.

On Mon, Feb 13, 2017, 4:39 PM Sean B notifications@github.com wrote:

Curt,

Thanks but this is built on top of my kludgey workaround from 05c84e8 https://github.com/waterjump/volca-share/commit/05c84e886dfc9c2a8520a6baf8a26de72c8d024d. I tested it and i can still make the initial light and it's checkbox replace different values if i drag over other lights, then back over the original without a mouseup.

The real challenge is making it work starting from commit 1f76841 https://github.com/waterjump/volca-share/commit/1f768419e0cef4cc7558afe91ed02d0acd413194

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/waterjump/volca-share/pull/2#issuecomment-279531164, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_TxHfHjXJNaRBB5oYcOIOS6mTPTLRjks5rcM2ogaJpZM4Lw0Vn .