search

waterlink / rspec-json_expectations

Set of matchers and helpers to allow you test your APIs responses like a pro.
https://www.relishapp.com/waterlink/rspec-json-expectations/docs
MIT License
140 stars 23 forks source link

Require rspec/core #14

Closed graemeboyd closed 8 years ago

graemeboyd commented 8 years ago

Changes json_expectations to require rspec/core instead of rspec.

This allows json_expectations to be used with rspec-rails without explicity requiring the rspec gem in the Gemfile.

This is similar to this shoulda-matchers issue which was solved in the same way: https://github.com/thoughtbot/shoulda-matchers/issues/248

The recommended way to use rspec-rails is to put gem 'rspec-rails' in the Gemfile. This pulls in the rspec-core gem as a dependency but not the rspec gem. This means json_expecations will fail to find rspec in the require path. As the rspec gem is just a "meta gem" which includes rspec-core as a dependency, I've changed the json_expectations to require rspec/core instead.

waterlink commented 8 years ago

Thanks! I'm going to release a new version soon

waterlink commented 8 years ago

@graemeboyd I have released 1.3.0, that includes this change.

graemeboyd commented 8 years ago

Thank you!