Added support for rspec alias and add feature spec - Githubissues

waterlink / rspec-json_expectations

Set of matchers and helpers to allow you test your APIs responses like a pro.

https://www.relishapp.com/waterlink/rspec-json-expectations/docs

MIT License

140 stars 23 forks source link

Added support for rspec alias and add feature spec #19

Closed JanStevens closed 7 years ago

JanStevens commented 7 years ago

Fixes #18

JanStevens commented 7 years ago

Fails since rspec 2 does not have RSpec::Matchers::AliasedMatcher

waterlink commented 7 years ago

I feel like it is not necessary to drop RSpec2 support. One could disable the feature test for Rspec2 and also conditionally use or not use AliasedMatcher.

waterlink commented 7 years ago

While it is not necessary, I think it would be a good thing :)

JanStevens commented 7 years ago

So another MR for removing rspec 2 support?

waterlink commented 7 years ago

@JanStevens Yes

waterlink commented 7 years ago

@JanStevens I have merged the other PR. And now this has conflicts, could you please resolve them?

waterlink commented 7 years ago

@JanStevens Thank you! And I have released this as 2.1.0 to rubygems.