waterlink / rspec-json_expectations

Set of matchers and helpers to allow you test your APIs responses like a pro.
https://www.relishapp.com/waterlink/rspec-json-expectations/docs
MIT License
140 stars 23 forks source link

Add missing require for Forwardable #26

Closed graaff closed 5 years ago

graaff commented 7 years ago

The lack of this require is masked when running the features with bundler, since bundler itself requires forwardable, but there is no guarantee that this will always be the case when this code is used.

tsmacdonald commented 6 years ago

I have this issue as well. @waterlink, is there a reason not to merge this?

waterlink commented 5 years ago

Thank you! Merged, @graaff @tsmacdonald @rgarner @MothOnMars @tas50

iv-mexx commented 5 years ago

Would be great to get a release with this fix sometime soon! 👍

waterlink commented 5 years ago

will do that today! Thank you for the reminder. I'm just getting back to ruby after a long break. Have forgotten that merging into master is not enough! 😅

waterlink commented 5 years ago

Done. 2.2.0 is released (both git tag in releases and new gem version in rubygems).

iv-mexx commented 5 years ago

Excellent, thanks for your work! 👍