Refactor and improve elapsed time logic

waterlink / spec2.cr

Enhanced `spec` testing library for [Crystal](http://crystal-lang.org/).

MIT License

103 stars 22 forks source link

Refactor and improve elapsed time logic #29

Closed waterlink closed 8 years ago

waterlink commented 8 years ago

This PR:

Extracts without change contents of the private def elapsed_time to a class ElapsedTime in method to_s.
Extracts moving parts started_at and time_now as members of the class, that are defaulted to their respective values, but can be injected otherwise.
Covers code with tests using ReverseTDD techniques.
Refactors code to be easily change-able.
Adds missing functionality when elapsed time > 1 hour.
Removes helper method in abstract interface, instead using ElapsedTime.new.to_s directly when needed.

waterlink commented 8 years ago

/cc @marceloboeira Could you take a look?

marceloboeira commented 8 years ago

@waterlink looks good to me, actually pretty good. Feel embarrassed by my POC ahah. 👏🏻

waterlink commented 8 years ago

No worries :) I got a chance to use some of the techniques (namely, ReverseTDD) I am researching at the moment.

marceloboeira commented 8 years ago

@waterlink nice, I'll take a look at it.

waterlink commented 8 years ago

If you are talking about "Reverse TDD", most probably, you will need to wait for me to blog about it ;) The only thing that I can find on the internets, that describes similar concept is TDRE: https://dzone.com/articles/test-driven-reverse

marceloboeira commented 8 years ago

@waterlink please do, it seems very interesting.

waterlink commented 8 years ago

And here answer on SO about the same topic (and apparently, by the same author): http://stackoverflow.com/a/167910/2173355

waterlink commented 8 years ago

The only thing that is missing from the concept is that you need to use Mutational Testing techniques to verify correctness of tests you have written for any given piece of functionality.