After hooks should be run for failing tests

waterlink / spec2.cr

Enhanced `spec` testing library for [Crystal](http://crystal-lang.org/).

MIT License

103 stars 22 forks source link

After hooks should be run for failing tests #32

Closed RX14 closed 8 years ago

RX14 commented 8 years ago

I use after hooks to clean up after tests. If one test fails, the after hook fails to run and this causes every test after to fail. This makes it a little hard to figure out which test was the root cause.

I think after hooks should run even when the test fails, using a finally block.

waterlink commented 8 years ago

@RX14 Thanks for the idea. You are totally right here. Will merge #33 once green and release a new version.

waterlink commented 8 years ago

@RX14 I have released 0.8.0 version with the fix.