search

waterloo-rocketry / or-airbrake-plugin

Rocket airbrakes simulation using OpenRocket and Ansys CFD
1 stars 0 forks source link

Refactor #17

Closed patrick-gu closed 1 week ago

patrick-gu commented 2 weeks ago

Part of #9

@celery6

This change is Reviewable

patrick-gu commented 2 weeks ago

I think we should be careful about the burnout. With the handlings of events we haven't been very careful of what occurs when in the simulation process.

patrick-gu commented 2 weeks ago

@celery6 says burnout makes no sense as a flight data value (true)

celery6 commented 2 weeks ago

Yeah considering the existing FlightDataTypes, burnout doesn't make sense there. It's a discrete stage of flight, not a variable. We can store it as a private member somewhere? Or find a direct way to retrieve it from simulation data, since that's where it actually belongs. image

The logic is fine at least - it's exactly the same as how processor board handles it. image