search

waterloo-rocketry / website

Waterloo Rocketry Team Site
0 stars 1 forks source link

Add join page, changed navbar on all pages #116

Closed usephysics closed 4 years ago

usephysics commented 4 years ago

Added a new page at http://waterloorocketry.com/join. Has information and Q&As for students wanting to join the team.

Changed navbar on every page to include the join page - I put it at the front.

Also, changed my own title from "Member" to "Software"

This change is Reviewable

usephysics commented 4 years ago

Thanks for the review Wendi! I've implemented most of your suggestions; here's a few comments:

                    <h1 class="content-title">HOW DO I JOIN?</h1>
                    <p class="content-text">
                        If you haven't already, join our <a href="https://www.facebook.com/groups/uwrocketry/">Facebook group</a>

I'd suggest a target=_blank on the link here so that it opens in a new tab and doesn't redirect them away from the join page :0

Use of target=_blank is the coke vs pepsi equivalent of UX - the argument being, without using it, if the user wishes to open the page in a new tab, they have that choice. When using it, you've taken away choice from the user. I am on the side of not using it, but I'm not passionate about it - so if others think it's a good idea, that's fine with me

            <div class="row my-0 faq-container">
                <div class="col-10 col-md-8 col-lg-7 px-0 mx-auto">
                    <button class="btn text-left" type="button" data-toggle="collapse" data-target="#one" aria-expanded="false">

A UI thing I noticed was that when you click the toggle question button, it stays highlighted until you click elsewhere. Not a blocker I don't think, but it would be nice if it didn't stay highlighted :)

The highlight is removable, but it shouldn't be due to accessibility issues (keyboard only users). See here: http://www.outlinenone.com/

                        What you start off with will depend on what stage our projects are at, as well as your own preference and comfort level. 
                        There is usually a variety of ongoing tasks to choose from. Some examples of past projects that first-years have worked on are:
                        <br>- Designing a test operations procedures simulator in Python

For the sake of consistency with other lists on the site I think we should use a <ul> element here (bullet points, essentially), instead of manual line breaks and dashes. You can do this just by popping the bullet point inside <li> tags and wrapping the whole list in a <ul>:

<ul> 
    <li>Designing a test operations procedures simulator in Python</li>
</ul>

I tried this initially, but bootstrap wasn't cooperating

usephysics commented 4 years ago

@wendi-yu I've added the rest of what is unresolved on reviewable - I made the buttons a lighter grey but I checked rounding the FAQ and increasing its width and I don't think they look better