82 sections - Githubissues

watermarkchurch / wcc-contentful

An alternative to Contentful's contentful.rb ruby client, contentful_model, and contentful_rails gems all in one.

MIT License

2 stars 1 forks source link

82 sections #103

Closed gburgett closed 5 years ago

gburgett commented 6 years ago

Adds a number of predefined sections to wcc-contentful-app with associated section views
- section-block-text
- section-faq
- section-http-error
- section-marquee-text
- section-testimonial
- section-video
- section-video-highlight
Adds a rake task to make it easier to import a section definition from a space in the future.

$ rake -D
rake app:import_model[model,space]
    Imports a set of models from a space as a single template for the ModelGenerator.
    Usage: rake wcc:import_model[content-type-id,space-id?,extra-content-type-1,extra-content-type-2...]

fixes #82

watermarkchurch-bot commented 6 years ago

	1 Warning
:warning:	This is a big pull request - please break it up into smaller units of work

Generated by :no_entry_sign: Danger

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 470

0 of 0 changed or added relevant lines in 0 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.02%) to 95.482%

Files with Coverage Reduction	New Missed Lines	%
lib/wcc/contentful/simple_client/management.rb	1	93.1%
lib/wcc/contentful/simple_client/http_adapter.rb	2	63.64%
lib/wcc/contentful/simple_client/response.rb	4	95.7%
<!--	Total:	7	-->

Totals
Change from base Build 468:	0.02%
Covered Lines:	3339
Relevant Lines:	3497

💛 - Coveralls

coveralls commented 6 years ago

Coverage increased (+0.02%) to 95.482% when pulling 1ee34726438b56cfb30f01c9c1d2b13fd95c3d39 on 82_sections into a0f2ccde9abdc86d88f36d32dd06a81440b43763 on master.

gburgett commented 5 years ago

The folder structure for the generators is to group all things together that logically go with one "concept" - ex. if you install menus, they don't work without also having dropdownMenu and menuButton. Similarly, section-testimonials doesn't work without also having testimonials.

However, it's totally cool to import section-block-text into a project without also importing section-testimonials. Maybe we have a smaller site where we don't want all these sections - we just want to pick and choose 2 or 3 of them. Having them in different folders allows you to rails g wcc:model just the sections you want, instead of having to import all sections.