search

watermarkchurch / wcc-contentful

An alternative to Contentful's contentful.rb ruby client, contentful_model, and contentful_rails gems all in one.
MIT License
2 stars 1 forks source link

Registry fix #256

Closed gburgett closed 2 years ago

gburgett commented 2 years ago

Fixes a bug where two namespaces were sharing the same registry.

The symptom was that a paper-signs Page was instantiating a Papyrus::PageMetadata, because the WCC::Contentful::Model registry was in fact the same ruby hash as the Papyrus::Model registry. So, when the Papyrus::PageMetadata class got eager-loaded, it triggered the included hook which put it in the registry, and then the Paper Signs PageMetadata never got loaded.

watermarkchurch-bot commented 2 years ago
1 Warning
:warning: No issue referenced - please create an issue describing a single unit of work and reference it using "closes #[the issue number]"

Generated by :no_entry_sign: Danger

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.005%) to 94.028% when pulling 5176c69c82febe088bb07be07205870e14b9653d on registry_fix into c5dc87ef70e3eaa3114349a6ea8de7de4d7e4590 on master.