search

watermarkchurch / wcc-contentful

An alternative to Contentful's contentful.rb ruby client, contentful_model, and contentful_rails gems all in one.
MIT License
2 stars 1 forks source link

Allow the user to configure the delayed job's adapter and queue #61

Closed reidcooper closed 6 years ago

gburgett commented 6 years ago

So the main reason that the delayed_sync_job is :async is because it needs to be in the same process as the store for both the MemoryStore, and LazySyncStore when it uses an in-memory cache. It can't modify the rails process' in-memory cache when it's running in a Sidekiq worker in another process.

We felt it was lightweight enough that this wasn't a problem. Is there a particular reason y'all want to move it to another adapter?

reidcooper commented 6 years ago

@gburgett Okay, no problem. We can close this PR then. I have no reason to switch it to another adapter other than keeping it consistent.

gburgett commented 6 years ago

Thanks reid! Appreciate the PRs, keep 'em coming!