watermarkchurch-deployment
commented
6 years ago | 9 Warnings | |
|---|---|
| :warning: | This is a big pull request - please break it up into smaller units of work |
| :warning: | No issue referenced - please create an issue describing a single unit of work and reference it using “closes #[the issue number]” |
| :warning: | wcc-contentful-app/lib/wcc/contentful/app/model_validators.rb#L43 - Rubocop rule Style/ClassVars disabled in wcc-contentful-app/lib/wcc/contentful/app/model_validators.rb Please provide an explanation why this rule was disabled. |
| :warning: | wcc-contentful/lib/wcc/contentful/graphql/builder.rb#L62 - TODO added in wcc-contentful/lib/wcc/contentful/graphql/builder.rb - is there a card associated with that? |
| :warning: | wcc-contentful/lib/wcc/contentful/model.rb#L44 - Rubocop rule Style/ClassVars disabled in wcc-contentful/lib/wcc/contentful/model.rb Please provide an explanation why this rule was disabled. |
| :warning: | wcc-contentful/lib/wcc/contentful/store/base.rb#L85 - Rubocop rule Lint/UnusedMethodArgument disabled in wcc-contentful/lib/wcc/contentful/store/base.rb Please provide an explanation why this rule was disabled. |
| :warning: | wcc-contentful/lib/wcc/contentful/store/base.rb#L173 - TODO added in wcc-contentful/lib/wcc/contentful/store/base.rb - is there a card associated with that? |
| :warning: | wcc-contentful/lib/wcc/contentful/store/lazy_cache_store.rb#L113 - Rubocop rule Naming/MemoizedInstanceVariableName disabled in wcc-contentful/lib/wcc/contentful/store/lazy_cache_store.rb Please provide an explanation why this rule was disabled. |
| :warning: | wcc-contentful/lib/wcc/contentful/store/postgres_store.rb#L130 - TODO added in wcc-contentful/lib/wcc/contentful/store/postgres_store.rb - is there a card associated with that? |
| 3 Messages | |
|---|---|
| :book: | wcc-contentful/lib/wcc/contentful/graphql.rb#L9 - TODO added in wcc-contentful/lib/wcc/contentful/graphql.rb referencing https://zube.io/watermarkchurch/development/c/2234 |
| :book: | wcc-contentful/lib/wcc/contentful/model_builder.rb#L25 - TODO added in wcc-contentful/lib/wcc/contentful/model_builder.rb referencing https://github.com/dkubb/ice_nine |
| :book: | wcc-contentful/lib/wcc/contentful/store/lazy_cache_store.rb#L27 - TODO added in wcc-contentful/lib/wcc/contentful/store/lazy_cache_store.rb referencing https://github.com/watermarkchurch/wcc-contentful/issues/18 |
Generated by :no_entry_sign: Danger
Split the gem into two packages:
wcc-contentful- the "core" gem containing architecture-agnostic code for working with Contentful datawcc-contentful-app- Extends the core gem to define the structure of key content types & behavior common to Watermark Church websites.