81 extract menus - Githubissues

watermarkchurch / wcc-contentful

An alternative to Contentful's contentful.rb ruby client, contentful_model, and contentful_rails gems all in one.

MIT License

2 stars 1 forks source link

81 extract menus #97

Closed rorJeremy closed 6 years ago

rorJeremy commented 6 years ago

Convert wcc-contentful-app from normal a Ruby gem into a Rails engine
Extract menu_helper from theporch.live into wcc-contentful-app
Extract _menu-item.html.erb partial from theporch.live into wcc-contentful-app
Modify menu-item partial so that it assigns bootstrap 4 classes to items in our navbars
Update the 'generated_add_menus' file to include the latest schema migrations for menu, menuButton, dropdownMenu, and divider.
Created models for divider and dropdownMenu, so that when you run the rails generate wcc:model menu command, classes for divide and dropdownMenu will be added to the project, along with the menu and dropdownMenu.
Update the model validations for menu and menuButton.
Extract the menu_helper_spec from theporch.live
Add the 'bookmarkTitle' field for the 'section-Faq' content type in the content_types_mgmt_api.json file
Add the 'sectionLink' field for the 'menuButton' content type in the content_types_mgmt_api.json file

closes #81

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 451

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.457%

Totals
Change from base Build 441:	0.0%
Covered Lines:	3320
Relevant Lines:	3478

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 463

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 95.457%

Files with Coverage Reduction	New Missed Lines	%
lib/wcc/contentful/simple_client/typhoeus_adapter.rb	2	81.25%
<!--	Total:	2		-->

Totals
Change from base Build 441:	0.0%
Covered Lines:	3320
Relevant Lines:	3478

💛 - Coveralls

watermarkchurch-bot commented 6 years ago

	1 Warning
:warning:	Please limit commit subject line to 72 characters. 343fcabe183fb38831e520db522a140f4bbe7e3c

Generated by :no_entry_sign: Danger