search

watertap-org / watertap-reflo

WaterTAP-REFLO repository for development of renewable energy-driven desalination models.
Other
4 stars 11 forks source link

Test surrogate #104

Closed dguittet closed 8 months ago

dguittet commented 8 months ago

Fixed the random state for the surrogate tests and now they are passing. The tests still include the PySMO surrogate fitting. I re-ran the tests on Github CI a few times and it passed each time, so I hope the flakiness has been resolved.

src/watertap_contrib/reflo/solar_models/surrogate/trough/data/training_trough_surrogate.py is a script that runs the training. It's currently broken due to some changes to TroughSurrogateData. What should be done with this file? If the surrogate training functionality is now in another part of the code, then perhaps this file could be deleted? Otherwise, I could fix this file but there should probably be some way to check that it doesn't keep breaking in the future.

Fixes #95 via approach (1)

adam-a-a commented 8 months ago

src/watertap_contrib/reflo/solar_models/surrogate/trough/data/training_trough_surrogate.py is a script that runs the training. It's currently broken due to some changes to TroughSurrogateData. What should be done with this file? If the surrogate training functionality is now in another part of the code, then perhaps this file could be deleted? Otherwise, I could fix this file but there should probably be some way to check that it doesn't keep breaking in the future.

Still need to reflect on this a bit, but the PR looks great to me!

kurbansitterley commented 8 months ago

src/watertap_contrib/reflo/solar_models/surrogate/trough/data/training_trough_surrogate.py is a script that runs the training. It's currently broken due to some changes to TroughSurrogateData. What should be done with this file? If the surrogate training functionality is now in another part of the code, then perhaps this file could be deleted? Otherwise, I could fix this file but there should probably be some way to check that it doesn't keep breaking in the future.

Still need to reflect on this a bit, but the PR looks great to me!

When we first started making surrogates, I kept all of the files used to make the surrogates around so they didn't disappear somewhere, including this one. Now that we have a grip on surrogate building, we can safely delete any files not needed to run the tests. Can either do it in this PR or another.