Forward osmosis unit model and Trevi's system flowsheet

watertap-org / watertap-reflo

WaterTAP-REFLO repository for development of renewable energy-driven desalination models.

Other

4 stars 11 forks source link

Forward osmosis unit model and Trevi's system flowsheet #114

Open Zhuoran29 opened 4 months ago

Zhuoran29 commented 4 months ago

This PR integrates the forward osmosis (FO) model developed from the Trevi System's pilot project and includes the following features:

A property package describing the proprietary draw solution properties used by Trevi
An FO unit model and its associated test file
An example flowsheet of building Trevi's FO configuration
A cost model based upon the Trevi's system costing numbers
Documentation of both the unit model and example flowsheet

kurbansitterley commented 3 months ago

@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.

Zhuoran29 commented 3 months ago

@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.

@kurbansitterley , Sorry for the late response. Yes, I've been looking into it and it seemed to need some more efforts to solve the convergence issue (seems related to an expr_if-like expression, even when scaling factor and jacobian matrix both look good). I'll try to fix it asap.

kurbansitterley commented 3 months ago

@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.

@kurbansitterley , Sorry for the late response. Yes, I've been looking into it and it seemed to need some more efforts to solve the convergence issue (seems related to an expr_if-like expression, even when scaling factor and jacobian matrix both look good). I'll try to fix it asap.

If it is related to the expr_if, you should do a totally fresh install of your environment. There was a compatibility issue with a previous version of Pyomo that has since been fixed. So I'd recommend checking if that solves your problem first before going too much further down the rabbit hole.

Zhuoran29 commented 2 months ago

Hey @kurbansitterley, just fixed the converging issue of this PR. Sorry for taking long.

Zhuoran29 commented 1 month ago

@kurbansitterley , thanks for the constructive suggestions. I've modified some of them and responded to those that I didn't change. Please feel free to follow with further comments.