Open Zhuoran29 opened 4 months ago
@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.
@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.
@kurbansitterley , Sorry for the late response. Yes, I've been looking into it and it seemed to need some more efforts to solve the convergence issue (seems related to an expr_if
-like expression, even when scaling factor and jacobian matrix both look good). I'll try to fix it asap.
@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that.
@kurbansitterley , Sorry for the late response. Yes, I've been looking into it and it seemed to need some more efforts to solve the convergence issue (seems related to an
expr_if
-like expression, even when scaling factor and jacobian matrix both look good). I'll try to fix it asap.
If it is related to the expr_if
, you should do a totally fresh install of your environment. There was a compatibility issue with a previous version of Pyomo that has since been fixed. So I'd recommend checking if that solves your problem first before going too much further down the rabbit hole.
Hey @kurbansitterley, just fixed the converging issue of this PR. Sorry for taking long.
@kurbansitterley , thanks for the constructive suggestions. I've modified some of them and responded to those that I didn't change. Please feel free to follow with further comments.
This PR integrates the forward osmosis (FO) model developed from the Trevi System's pilot project and includes the following features: