Multi-effect crystallizer unit model

watertap-org / watertap-reflo

WaterTAP-REFLO repository for development of renewable energy-driven desalination models.

Other

4 stars 11 forks source link

Multi-effect crystallizer unit model #121

Closed Zhuoran29 closed 2 weeks ago

Zhuoran29 commented 3 months ago

This PR adds:

CrystallizerEffect unit model
MultiEffectCrystallizer unit model that is comprised of n CrystallizerEffect unit models connected via constraints
test files for both
costing for MultiEffectCrystallizer and CrystallizerEffect
importantly, this PR also points to watertap==1.0.0rc0 in setup.py

TODO:

[x] check units on heat transfer equations
[x] test file for CrystallizerEffect
[x] determine if flow_vol_phase['Vap'] is the proper flow to cost for steam
[x] remove name == "main" in unit model files

kurbansitterley commented 3 months ago

@Zhuoran29 can you run black so we can see the results of the GH tests please?

Zhuoran29 commented 3 months ago

@Zhuoran29 can you run black so we can see the results of the GH tests please?

Sure, it seems the cost package is not adjusted well and I'll look into it.

Zhuoran29 commented 2 months ago

I added the costing package from the WaterTAP repo and a test file for the flowsheet, where both simulation and optimization modes were tested.

Zhuoran29 commented 2 months ago

Hey @kurbansitterley @adam-a-a , forgot to tag you when I updated this PR.

kurbansitterley commented 1 month ago

I have just noticed both watertap-org/watertap#1482 and watertap-org/watertap#1487 that are modifying either the unit model itself or the property package it uses. If we are going to inherit Crystallization for the MultiEffectCrystallizer, we might want to wait to see what changes are made there, especially if we want to keep updating the watertap dependency.

adam-a-a commented 2 weeks ago

My other general comment is we definitely want to document the single and multieffect models thoroughly--though that can happen in a subsequent PR down the line and shouldn't hold this up.

Zhuoran29 commented 2 weeks ago

I ran a few cases and the results are looking good to me! Also I added a test for an optimization scenario in case it's helpful to the case study. If the additions look good to you then I think it's good to go, but please feel free to not include it. @kurbansitterley