search

watertap-org / watertap-reflo

WaterTAP-REFLO repository for development of renewable energy-driven desalination models.
Other
4 stars 11 forks source link

Thermal unit models; SolarModelBase improvements #98

Closed MuktaHardikar closed 9 months ago

MuktaHardikar commented 9 months ago
  1. Added the flat plat collector physical model with some modifications- included ports for the heating fluid, calculating the heat_load.
  2. Added the thermal energy storage model. The calculation for the thermal_energy_capacity needs to be reviewed
  3. Added the cost functions for both.
Zhuoran29 commented 9 months ago

Thanks @MuktaHardikar, it all looks great and useful! Just have some details that I'm not sure about as commented in the code.

kurbansitterley commented 9 months ago

I have a few comments but will approve so as not to hold up the PR. I will say this PR is pretty large, making it tougher or and a bit more confusing to review (thoroughly). For future PRs, would be nice to break these PRs up into much smaller chunks.

Agreed, this one got away from me as soon as I tried to add the flat plate surrogate to it.

I am going to address a few of these comments and then merge.