watertap-org / watertap

The WaterTAP development repository
https://watertap.readthedocs.io/en/latest
Other
60 stars 59 forks source link

Improve integration of OLI API CI workflows #1249

Open lbianchi-lbl opened 11 months ago

lbianchi-lbl commented 11 months ago

The OLI API functionality is tested via external CI workflows, i.e. running outside of this public repository. This allows us to test a more complete set of features, however it results in a number of shortcomings:

This issue is to track progress on improving the integration by addressing the points described above.

lbianchi-lbl commented 9 months ago

As a first (and possibly "good enough" in an 80/20 kind of way) solution, using the create commit status functionality in the GitHub API seems to work:

image

This doesn't address the coverage issue, but at least make it much easier to know the outcome of the CI workflow for a specific PR.

adam-a-a commented 9 months ago

As a first (and possibly "good enough" in an 80/20 kind of way) solution, using the create commit status functionality in the GitHub API seems to work:

image

This doesn't address the coverage issue, but at least make it much easier to know the outcome of the CI workflow for a specific PR.

Sounds like a good start (or "good enough finish").