Electrodialysis Feature Requests

[hunterbarber]

Description

Master-issue list of features that may be relevant to increase the fidelity of the electrodialysis model.

• [ ] Non-rectangular baffled flow paths through rectangular cell and membrane geometry. This can be handled in the unit model through either inputting the cell width as an effective cell width or adding an effective permeation area variable, however this needs appropriately handled in the costing package which also utilizes width*length.
• [ ] Potentially decouple electrically- and diffusion-driven transport for accurate current_efficiency_x calculations which would hold true (0, 1) bounds
• [ ] eq_get_current_density and eq_get_current_density construct the same equations
• [ ] if hasattr(self, "potential_ohm_dl_x"): line 2488 should also be indexed by itself
• [ ] Index pressure drop for each channel
• [ ] Typo in length in line 149
• [ ] cost_rectifier adds captial_cost to costing block twice
• [ ] Typo in stack_electrode_captical_cost

Motivation

List is a combination of features to add model fidelity and general changes for stability, initialization, etc.

Additional Context

List is mostly to itemize ideas, and subsequent changes in PR's are to be decided upon. Some features may only be implemented at the flowsheet level and not relevant to apply at the base model, which would not require a PR.

[lbibl]

I am checking off the first box as I think, at this point, that should be addressed at the flowsheet level. Not complicating fluid conditions in the current ED model in the foreseen future is my understanding.

I am not sure about the second box because the designed current_efficiency is for accounting for the impact of diffusion.

The last two boxes do not point me toward the clear issues.