watertap-org / watertap

The WaterTAP development repository
https://watertap.readthedocs.io/en/latest
Other
60 stars 59 forks source link

Running TO-DO for conventional BSM2 Flowsheet #1318

Open adam-a-a opened 8 months ago

adam-a-a commented 8 months ago

There are some outstanding to-do items for the BSM2 flowsheet, most of which were mentioned in #1244:

adam-a-a commented 1 month ago

We should revisit " Resolve final iterations of BSM2 flowsheet having regularization" and make sure this wasn't confused with ending in restoration. Either way, let's check the conventional BSM2 flowsheet solver output.

adam-a-a commented 3 weeks ago

change ref to m.fs.Treated instead of CL1 effluent in add_effluent_violations function

@MarcusHolly attempted to make this change, but for some reason, it caused test failures for the GUI, and so the changes were undone. We should revisit this issue at some point.