watertap-org / watertap

The WaterTAP development repository
https://watertap.readthedocs.io/en/latest
Other
54 stars 54 forks source link

Dynamically defining feed composition in GUI #1410

Open adam-a-a opened 1 month ago

adam-a-a commented 1 month ago

For flowsheets that use the MCAS property model, we should be able to allow the user to define what ions/solutes are in the desired composition. While we can have some default composition with default concentrations to start if the user doesn't care to change this, the user should be able to define feed composition. I would consider this to be one of the core requirements that any water treatment modeling application should have. Now that we have "model config options" for flowsheets, we should be able to setup feed composition in the same manner.

@MichaelPesce @dangunter

adam-a-a commented 1 month ago

The nf_ui example is the first example that comes to mind although the user would also need to provide solute properties which are required by the nf unit model. Namely, they'd need to provide molecular weight, charge, Stokes radius, and diffusivity for each component. We might be able to get away with excluding molecular weight and charge since I built in some capability to load those automatically, granted that said components are found in a lookup table corresponding to the periodic table.

avdudchenko commented 1 week ago

We do have the build options that could be used for this, however we would need to enable user to dynamically add additional options in form of ion species predefined by developer. - an alternative might be to give a user an option to point to a config file? This would also remove the need for a user to always reenter all the options etc. but not sure if its really a good options